Dylan Reid - Pet Park Assignment #37
Conversation
|
|
||
| // define struct of animal type, age, and gender | ||
| struct animalAndDemo { | ||
| uint animalType; |
There was a problem hiding this comment.
You can use enums for animal type and gender
| address owner; | ||
|
|
||
| // define struct of animal type, age, and gender | ||
| struct animalAndDemo { |
There was a problem hiding this comment.
The general convention is to have the first letter as uppercase in names of structs, classes and events
| emit Added(animalType, count); | ||
| } | ||
|
|
||
| function borrow(uint age, uint gender, uint animalType) public animalRange(animalType) { |
There was a problem hiding this comment.
This can be marked external since it is not being called anywhere internally
|
|
||
| function add(uint animalType, uint count) public animalRange(animalType) { | ||
| // check that only owner has access | ||
| require(owner == msg.sender, "Not an owner"); |
There was a problem hiding this comment.
Better to check this with a modifier as it make the code more readable
|
|
||
| function animalCounts(uint animalType) public view returns(uint) { |
There was a problem hiding this comment.
Since solidity public mappings are automatically exposed as functions, you can just make animalCounts as a public mapping. Here you just have to rename animalsInZoo to animalCounts
|
|
||
| // set animal type back to zero in borrow mapping | ||
| uint currentAge = borrowedAnimal[msg.sender].age; | ||
| uint currentGender = borrowedAnimal[msg.sender].gender; |
There was a problem hiding this comment.
Since borrowedAnimal[msg.sender] is being used multiple times it can be stored in a single memory variable. Later in the course you will learn that it is a gas optimisation technique
| uint gender; | ||
| } | ||
|
|
||
| // animals in zoo: animalType and count of that animal in the zoo |
There was a problem hiding this comment.
In solidity it is recommended to use Natspec format for commenting
No description provided.